Fix unsupported MySQL temporary table DDL before backend execution#38829
Open
Zhengcy05 wants to merge 1 commit into
Open
Fix unsupported MySQL temporary table DDL before backend execution#38829Zhengcy05 wants to merge 1 commit into
Zhengcy05 wants to merge 1 commit into
Conversation
565c817 to
2bbb1aa
Compare
2bbb1aa to
c803e13
Compare
Author
|
@linghengqian Sorry to bother you, the E2E test failed due to Maven download network issue, could you please help re-run the failed job? |
linghengqian
left a comment
Member
There was a problem hiding this comment.
Sorry to bother you, the E2E test failed due to Maven download network issue, could you please help re-run the failed job?
I have restarted CI.
I'm not entirely sure about the background of the original issue, and I personally think the current PR needs other committers to help review it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38709.
Changes
Changes proposed in this pull request:
TEMPORARYsemantics inCreateTableStatementandDropTableStatementMySQLDDLStatementVisitorKernelProcessorto rejectCREATE TEMPORARY TABLEandDROP TEMPORARY TABLEUnsupportedSQLOperationExceptionbefore SQL is sent to backendTests
Added regression coverage for:
Executed tests:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.