Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the record list query does not support new OAP versions #197

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix the record list query does not support new OAP versions #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Release Notes.
------------------

### Features

### Bug Fixes

* Fix the record list query does not support new OAP versions (with major version number > 9).

## What's Changed

* Add the sub-command `menu get` for get the ui menu items by @mrproliu in https://github.com/apache/skywalking-cli/pull/187
Expand Down
2 changes: 1 addition & 1 deletion internal/commands/metrics/aggregation/sampled-record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ $ swctl metrics sampled-record --name top_n_database_statement 5
}

// since 9.3.0, use new record query API
if major >= 9 && minor >= 3 {
if (major == 9 && minor >= 3) || major > 9 {
condition, duration, err1 := buildReadRecordsCondition(ctx)
if err1 != nil {
return err1
Expand Down
Loading