Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fish and zsh completion support #207

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: add fish and zsh completion support #207

merged 1 commit into from
Dec 23, 2024

Conversation

chenrui333
Copy link
Contributor

would be nice to also support fish and zsh completions. (seeing the completions while reviewing Homebrew/homebrew-core#202118)

@CodePrometheus CodePrometheus added the enhancement New feature or request label Dec 22, 2024
@CodePrometheus CodePrometheus added this to the 0.15.0 milestone Dec 22, 2024
@wu-sheng
Copy link
Member

@CodePrometheus What is the release policy for us to push further releases there?

You should update cli docs about that.

@wu-sheng
Copy link
Member

@chenrui333 Please fix CI.

@CodePrometheus
Copy link
Contributor

CodePrometheus commented Dec 23, 2024 •
edited
Loading

@CodePrometheus What is the release policy for us to push further releases there?

I have added swctl to autobump, the Homebrew‘s robot will automatically update it after we release the version.

You should update cli docs about that.

I will update the brew usage instructions in README after swctl is pushed in Homebrew

@wu-sheng
Copy link
Member

Are they monitoing git tag or somewhere for our release?

@CodePrometheus
Copy link
Contributor

Are they monitoing git tag or somewhere for our release?

AFAIK, homebrew's bot triggers brew bump for the formula to be autobumped every three hours through github-actions, it will get releases/latest through api.github.com based on the information I configured (repo, url, etc.).
@chenrui333 Please kindly correct me if I'm wrong, thanks :)

@chenrui333
Copy link
Contributor Author

Are they monitoing git tag or somewhere for our release?

AFAIK, homebrew's bot triggers brew bump for the formula to be autobumped every three hours through github-actions, it will get releases/latest through api.github.com based on the information I configured (repo, url, etc.). @chenrui333 Please kindly correct me if I'm wrong, thanks :)

yeah, it would be based on git tag.

@wu-sheng wu-sheng merged commit 3f9cf0e into apache:master Dec 23, 2024
7 checks passed
@chenrui333 chenrui333 mentioned this pull request Dec 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodePrometheus CodePrometheus CodePrometheus approved these changes

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @wu-sheng @CodePrometheus