-
Notifications
You must be signed in to change notification settings - Fork 107
Support Gozero #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support Gozero #230
Conversation
|
Please fix CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix all the comment and add a new plugin test for it.
go.mod
Outdated
| require ( | ||
| github.com/google/uuid v1.3.0 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/segmentio/kafka-go v0.4.48 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why there have dependency changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run go mod tidy, Kafka is automatically added to go.mod. Using go mod why, I found that it is being used in the reporter.
go mod why -m github.com/segmentio/kafka-go
# github.com/segmentio/kafka-go
github.com/apache/skywalking-go/agent/reporter
github.com/segmentio/kafka-goThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go mod tidy is use for the single module, in the go work concept, you should use go work sync.
|
Why does this commit hash appear to be wrong? My last commit ID is 3012842, but the CI build is using 4b51072. I expected the CI to build the latest commit, so I’m trying to understand why it’s picking an error one. @mrproliu thanks.
|
|
It will merge the main branch into your branch, so it's fine to run this. You should focus on the CI issue, rather than the commit ID. |
Support Gozero framework