Skip to content

Conversation

@youngxhui
Copy link
Contributor

Support Gozero framework

@wu-sheng wu-sheng requested review from Copilot and mrproliu August 24, 2025 03:14
@wu-sheng wu-sheng added the enhancement New feature or request label Aug 24, 2025
@wu-sheng wu-sheng added this to the 0.7.0 milestone Aug 24, 2025
@wu-sheng
Copy link
Member

Please fix CI.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

@mrproliu mrproliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix all the comment and add a new plugin test for it.

go.mod Outdated
require (
github.com/google/uuid v1.3.0
github.com/pkg/errors v0.9.1
github.com/segmentio/kafka-go v0.4.48
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there have dependency changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run go mod tidy, Kafka is automatically added to go.mod. Using go mod why, I found that it is being used in the reporter.

go mod why -m github.com/segmentio/kafka-go
# github.com/segmentio/kafka-go
github.com/apache/skywalking-go/agent/reporter
github.com/segmentio/kafka-go

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy is use for the single module, in the go work concept, you should use go work sync.

@youngxhui
Copy link
Contributor Author

Why does this commit hash appear to be wrong? My last commit ID is 3012842, but the CI build is using 4b51072. I expected the CI to build the latest commit, so I’m trying to understand why it’s picking an error one. @mrproliu thanks.

CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -v -ldflags "-X main.version=4b51072 -X main.gitCommit=4b51072" -o /home/runner/work/skywalking-go/skywalking-go/tools/go-agent/../..//bin/skywalking-go-agent-4b51072-linux-amd64 ./cmd
https://github.com/apache/skywalking-go/actions/runs/17224357417/job/48866299992?pr=230

@mrproliu
Copy link
Contributor

It will merge the main branch into your branch, so it's fine to run this. You should focus on the CI issue, rather than the commit ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants