[SPARK-54352] [SQL] Introduce SQLConf.canonicalize to centralize normalization of strings
#53063
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihailoale-db
force-pushed
the
canonicalizer
branch
from
120cd21 to
9441bb7
Compare
Contributor
Author
|
@dtenedor @cloud-fan PTAL when you find time. Thanks! |
cloud-fan
approved these changes
Nov 17, 2025
Contributor
|
thanks, merging to master! |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM, too. Thank you, @mihailoale-db and @cloud-fan .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose that we introduce
SQLConf.canonicalizeto centralize normalization of strings. This will help us avoid the code duplication and ease the development of the single-pass analyzer.Why are the changes needed?
To ease the development of the single-pass analyzer (avoid code duplication).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.