scheduler: replace reflection with @VisibleForTesting in IsolationSchedulerTest#8811
Merged
Merged
Conversation
…edulerTest Make IsolationScheduler#hostAssignableSlots package-private and annotate it with @VisibleForTesting so the test can call it directly instead of using reflection, which is fragile under refactoring. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closes #8806 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IsolationScheduler#hostAssignableSlotspackage-private and annotates it with@VisibleForTestingIsolationSchedulerTestthat calledsetAccessible(true)to reach the private methodhostAssignableSlotsdirectly;throws Exceptionremoved from both test signaturesMotivation
As suggested in #8709 (comment) — reflection-based test helpers are fragile (silently break on method renames, signature changes, or module boundary changes) and harder to maintain. The
@VisibleForTestingpattern is already used elsewhere instorm-server(e.g.Supervisor.java) and makes the intent explicit without exposing the method publicly.Test plan
mvn test -pl storm-server -Dtest=IsolationSchedulerTestpasses🤖 Generated with Claude Code