Set the CORS filter credentials parameter explicitly instead of a header name the filter ignores - #8976
Merged
Merged
Conversation
GGraziadei
approved these changes
Aug 21, 2026
GGraziadei
left a comment
GGraziadei
left a comment
Member
There was a problem hiding this comment.
Hi Richard, thanks, LGTM.
GitHub flagged some methods as deprecated and marked for removal (but not on the changed lines). This is a separate issue that we can address in the future.
reiabreu
approved these changes
Aug 22, 2026
rzo1
force-pushed
the
fix/webapp-cors-filter-defaults
branch
from
August 22, 2026 16:54
e4d7bd4 to
e779409
Compare
…der name that the filter ignores
rzo1
force-pushed
the
fix/webapp-cors-filter-defaults
branch
from
August 22, 2026 17:08
e779409 to
ad0811d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
corsFilterHandlepassedCrossOriginFilter.ACCESS_CONTROL_ALLOW_ORIGIN_HEADER, a response header name, where an init-param name was expected, so Jetty ignored the line and the filter ran on its own defaults.Sets
ALLOW_CREDENTIALS_PARAMexplicitly and pins all four init-params inUIHelpersTest.