fix(deckgl-plugin): make filters work in multiple layers chart #33009

syedbarimanjan · 2025-04-06T07:18:56Z

SUMMARY

Filters werent applying to multiple layers deck.gl chart because they werent being passed down to the sublayers properly. Fixes #13731

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screencast_20250406_121214.webm

Screencast_20250406_122058.webm

korbit-ai

I've completed my review and didn't find any issues.

Files scanned

File Path	Reviewed
superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/Multi.tsx	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.

You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.

Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.

On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.

Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

Check out our docs on how you can make Korbit work best for you and your team.

Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

Setting Value

Review Schedule Automatic excluding drafts

Max Issue Count 10

Automatic PR Descriptions ❌

Issue Categories

Category Enabled

Documentation ✅

Logging ✅

Error Handling ✅

Readability ✅

Design ✅

Performance ✅

Security ✅

Functionality ✅

Feedback and Support

Tell us what you think of Korbit

Schedule a call with our team

Email us @ [email protected]

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

github-actions

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

syedbarimanjan · 2025-04-06T09:10:33Z

@geido

AllProAi · 2025-04-06T17:06:32Z

o.O

DarksChoise · 2025-04-06T21:44:50Z

@geido

github-actions · 2025-04-07T10:26:30Z

@geido Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

github-actions · 2025-04-07T10:33:52Z

@geido Ephemeral environment spinning up at http://35.90.100.196:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

…2839)

sadpandajoe · 2025-04-07T17:25:58Z

Is this a duplicate of #33008? cc: @geido

syedbarimanjan · 2025-04-07T17:30:56Z

Is this a duplicate of #33008? cc: @geido

That is an ai bot which copied my code from my fork before I could create and pr I had told diego that I have the fix for it and I am also assigned to the issue. That one also doesnt has the extra code which I have here which adds the adhoc filters to the multiple layer chart because I hadnt pushed it to my fork.

…pache#32890) Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: Geido <[email protected]>

AllProAi · 2025-04-07T18:18:52Z

I'm not a bot... also wow. Not claiming bounty though I need the cash was trying to provide a solution for goku... i have full records of finding the issue in code I didn't know you existed before you posted brother chill out.

syedbarimanjan · 2025-04-07T18:23:54Z

I'm not a bot... also wow. Not claiming bounty though I need the cash was trying to provide a solution for goku... i have full records of finding the issue in code I didn't know you existed before you posted brother chill out.

Sorry I thought that it was a bot(because you have ai in your name).

…nd Charts (apache#30833) Co-authored-by: Asher Manangan <[email protected]>

…/docs (apache#33028) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…e#33046)

codecov · 2025-05-02T16:58:00Z

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 75.84%. Comparing base (629b137) to head (96fe6c4).
Report is 101 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/viz.py	0.00%	16 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #33009       +/-   ##
===========================================
+ Coverage        0   75.84%   +75.84%     
===========================================
  Files           0      553      +553     
  Lines           0    39980    +39980     
===========================================
+ Hits            0    30323    +30323     
- Misses          0     9657     +9657

Flag	Coverage Δ
hive	`48.23% <0.00%> (?)`
mysql	`75.35% <0.00%> (?)`
postgres	`75.41% <0.00%> (?)`
presto	`52.68% <0.00%> (?)`
python	`75.84% <0.00%> (?)`
sqlite	`74.90% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ocs (apache#33314) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#33320) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

rusackas · 2025-05-02T17:43:19Z

Appreciate the PR! Looks like CI needs some love... let us know if you can make heads or tails of any of it.

…ze_columns is enabled (apache#33337)

… /docs (apache#33315) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…rrors (apache#33354)

…bariman:syedbarimanjan/superset into fix-deckgl-multiple-layer-chart-filters

fix(deckgl-plugin): make filters work in multiple layers chart

7f24fa6

pull-request-size bot added the size/S label Apr 6, 2025

github-actions bot added the plugins label Apr 6, 2025

dosubot bot added the viz:charts:deck.gl Related to deck.gl charts label Apr 6, 2025

korbit-ai bot reviewed Apr 6, 2025

View reviewed changes

github-actions bot reviewed Apr 6, 2025

View reviewed changes

geido added the testenv-up label Apr 7, 2025

geido added hold! On hold preset:bounty Issues that have been selected by Preset and have a bounty attached. labels Apr 7, 2025

LevisNgigi and others added 2 commits April 7, 2025 18:20

fix: fix bug where dashboard did not enter fullscreen mode. (apache#3…

b6df88a

…2839)

docs: Update documentation about publishing a dashboard (apache#32999)

c131205

refactor(IconButton): Refactor IconButton to use Ant Design 5 Card (a…

e1383d3

…pache#32890) Co-authored-by: Maxime Beauchemin <[email protected]> Co-authored-by: Geido <[email protected]>

asher-lab and others added 9 commits April 7, 2025 15:12

feat(tags): Export and Import Functionality for Superset Dashboards a…

fd947a0

…nd Charts (apache#30833) Co-authored-by: Asher Manangan <[email protected]>

fix(log): Missing failed query log on async queries (apache#33024)

9b15e04

docs: add WinWin Network（马上赢） to users list (apache#33018)

15969fd

chore(deps): bump estree-util-value-to-estree from 3.1.1 to 3.3.3 in …

5a8eab3

…/docs (apache#33028) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix(export): charts csv export in dashboards (apache#31720)

6b7394e

chore(helm): bump appVersion to 4.1.2 (apache#33061)

3a57857

docs: clarify docker-compose-image-tag instructions (apache#33045)

9280b4d

fix: improve error type on parse error (apache#33048)

ed0cd5e

feat: add a title prop to the dashboard link in CRUD LIST view (apach…

deb6aed

…e#33046)

michael-s-molina and others added 2 commits May 2, 2025 08:27

fix: Temporal filter conversion in viz migrations (apache#33224)

6db3a4d

fix(deckgl-plugin): fix viewport for multiple layers chart

96fe6c4

pull-request-size bot added size/L and removed size/S labels May 2, 2025

dependabot bot added 2 commits May 2, 2025 10:59

chore(deps-dev): bump eslint-plugin-react from 7.37.4 to 7.37.5 in /d…

c22c532

…ocs (apache#33314) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps-dev): bump typescript from 5.8.2 to 5.8.3 in /docs (apache…

5a9e366

…#33320) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Vitor-Avila and others added 7 commits May 2, 2025 18:20

fix: Edge case with metric not getting quoted in sort by when normali…

9f0ae77

…ze_columns is enabled (apache#33337)

chore(deps-dev): bump eslint-config-prettier from 10.1.1 to 10.1.2 in…

7791674

… /docs (apache#33315) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: loading examples from raw.githubusercontent.com fails with 429 e…

f045a73

…rrors (apache#33354)

fix(deckgl-plugin): make filters work in multiple layers chart

4bc8dcb

fix(deckgl-plugin): fix viewport for multiple layers chart

d9d4be8

Merge branch 'fix-deckgl-multiple-layer-chart-filters' of github.com-…

2546156

…bariman:syedbarimanjan/superset into fix-deckgl-multiple-layer-chart-filters

fix(deckgl): fix remaining deckgl charts viewport

a069331

syedbarimanjan requested review from villebro, rusackas, geido, eschutho, betodealmeida, nytai, mistercrunch, craig-rueda, kgabryje, dpgaspar, sadpandajoe, michael-s-molina and Antonio-RiveroMartnez as code owners May 5, 2025 15:49

syedbarimanjan closed this May 5, 2025

syedbarimanjan deleted the fix-deckgl-multiple-layer-chart-filters branch May 5, 2025 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(deckgl-plugin): make filters work in multiple layers chart #33009

fix(deckgl-plugin): make filters work in multiple layers chart #33009

Uh oh!

syedbarimanjan commented Apr 6, 2025 •

edited

Loading

Uh oh!

korbit-ai bot left a comment •

edited

Loading

Uh oh!

github-actions bot left a comment

Uh oh!

syedbarimanjan commented Apr 6, 2025

Uh oh!

AllProAi commented Apr 6, 2025

Uh oh!

DarksChoise commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

sadpandajoe commented Apr 7, 2025

Uh oh!

syedbarimanjan commented Apr 7, 2025 •

edited

Loading

Uh oh!

AllProAi commented Apr 7, 2025

Uh oh!

syedbarimanjan commented Apr 7, 2025

Uh oh!

codecov bot commented May 2, 2025 •

edited

Loading

Uh oh!

rusackas commented May 2, 2025

Uh oh!

Uh oh!

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	❌

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

fix(deckgl-plugin): make filters work in multiple layers chart #33009

fix(deckgl-plugin): make filters work in multiple layers chart #33009

Uh oh!

Conversation

syedbarimanjan commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Uh oh!

korbit-ai bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Interacting with Korbit

Customizing Korbit

Current Korbit Configuration

Feedback and Support

Looking to add Korbit to your team? Get started with a free 2 week trial here

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

syedbarimanjan commented Apr 6, 2025

Uh oh!

AllProAi commented Apr 6, 2025

Uh oh!

DarksChoise commented Apr 6, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

sadpandajoe commented Apr 7, 2025

Uh oh!

syedbarimanjan commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AllProAi commented Apr 7, 2025

Uh oh!

syedbarimanjan commented Apr 7, 2025

Uh oh!

codecov bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rusackas commented May 2, 2025

Uh oh!

Uh oh!

syedbarimanjan commented Apr 6, 2025 •

edited

Loading

korbit-ai bot left a comment •

edited

Loading

syedbarimanjan commented Apr 7, 2025 •

edited

Loading

codecov bot commented May 2, 2025 •

edited

Loading