Skip to content

chore: Bump FAB to 5.X #33055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

chore: Bump FAB to 5.X #33055

wants to merge 15 commits into from

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Apr 9, 2025

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Apr 9, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Apr 9, 2025
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.25%. Comparing base (7530487) to head (85bcdfb).

Files with missing lines Patch % Lines
superset/migrations/env.py 0.00% 2 Missing ⚠️
superset/views/base.py 60.00% 2 Missing ⚠️
superset/security/manager.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33055       +/-   ##
===========================================
+ Coverage        0   83.25%   +83.25%     
===========================================
  Files           0      553      +553     
  Lines           0    39925    +39925     
===========================================
+ Hits            0    33239    +33239     
- Misses          0     6686     +6686     
Flag Coverage Δ
hive 48.29% <45.16%> (?)
mysql 75.46% <83.87%> (?)
postgres 75.53% <83.87%> (?)
presto 52.76% <51.61%> (?)
python 83.25% <83.87%> (?)
sqlite 75.03% <83.87%> (?)
unit 61.32% <45.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the api Related to the REST API label Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API review:draft risk:db-migration PRs that require a DB migration size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants