Skip to content

Do 82/timer change#40992

Closed
alekseisti wants to merge 3 commits into
apache:masterfrom
Piletilevi:DO-82/Timer-change
Closed

Do 82/timer change#40992
alekseisti wants to merge 3 commits into
apache:masterfrom
Piletilevi:DO-82/Timer-change

Conversation

@alekseisti

Copy link
Copy Markdown

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 5cf1b7f
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a2bc3e65ca0ec00087a518e
😎 Deploy Preview https://deploy-preview-40992--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@bito-code-review bito-code-review Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #ac8642

Actionable Suggestions - 1
  • .github/workflows/sbom.yaml - 1
Additional Suggestions - 1
  • .github/workflows/sbom.yaml - 1
    • External action lacks inline documentation · Line 15-17
      The external action `Piletilevi/sec-workflows/.github/workflows/sbom-upload.yaml@v2` is referenced without documentation. Other security workflows in the repo (e.g., dependency-review.yml) include comments linking to source repository and documentation. Adding similar context improves maintainability.
      Code suggestion
      --- .github/workflows/sbom.yaml
      +++ .github/workflows/sbom.yaml
       @@ -0,0 +1,6 @@
      +# SBOM Upload to Dependency-Track
      +#
      +# Uploads Software Bill of Materials to OWASP Dependency-Track for security analysis.
      +# Source: Piletilevi/sec-workflows
      +
        name: SBOM
Review Details
  • Files reviewed - 3 · Commit Range: 4bb90cc..5cf1b7f
    • .github/workflows/sbom-deactivate.yaml
    • .github/workflows/sbom-findings.yaml
    • .github/workflows/sbom.yaml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo


jobs:
sbom:
uses: Piletilevi/sec-workflows/.github/workflows/sbom-upload.yaml@v2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing concurrency control

Add a top-level concurrency section (e.g., concurrency: group: sbom-${{ github.ref }} cancel-in-progress: true) similar to sbom-findings.yaml and sbom-deactivate.yaml to prevent overlapping workflow runs.

Code Review Run #ac8642


Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

@rusackas

Copy link
Copy Markdown
Member

Can we get a PR description on this one? No idea what this is for, thus far.

@rusackas

Copy link
Copy Markdown
Member

Haven't heard back of what this is, so I'll close it for now. Please feel free to reopen!

@rusackas rusackas closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants