Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIKA-4365 : feat : Support Detection for AAB Bundle file #2085

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

subbudvk
Copy link
Contributor

@subbudvk subbudvk commented Jan 3, 2025

TIKA-4365 : Support added for Android AAB bundle file.

Detection is through AndroidManifest.xml similar to APK files in JarDetector. As per Android Developer Documentation this file is seen in manifest directory.

https://developer.android.com/guide/app-bundle/app-bundle-format

@tballison
Copy link
Contributor

I'm sorry for my delay on this. Is there a reason to put the android logic in the jar detector instead of a separate detector? The good thing about the current PR is that it guarantees the order of detectors.

@subbudvk
Copy link
Contributor Author

@tballison you are right. The Jar detector decides content based on the presence of MANIFEST.MF. The android package bundle will also have MANIFEST.MF, so to guarantee the order and JarDetector doesn't return jar based on MANIFEST.MF and since other android types are already handled in JarDetector, I changed here.

Let me know if you have comments.

Add a brief description of the scope of the JarDetector beyond jars.
@tballison
Copy link
Contributor

tballison commented Jan 24, 2025

I'll merge this as soon as the checks pass. On a follow-on PR, if you have a chance, would you be able to create/find an ASL 2.0-compatible test file for a unit test ... and the unit test of course. :D

@tballison tballison merged commit bb775c1 into apache:main Jan 24, 2025
1 check failed
@subbudvk
Copy link
Contributor Author

I will add tests for this @tballison. Thanks for the help!

@tballison
Copy link
Contributor

tballison commented Jan 24, 2025

I just merged into main. I'll fix checkstyle now. I should have checked out your branch, etc. Sorry. Fixes incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants