ArgParser: Add mutually exclusive option groups #12621
Open
+530
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement support for mutually exclusive option groups in ArgParser, allowing options that cannot be used together to be properly validated and documented. This feature is useful for conflicting options like --verbose/--quiet or --enable/--disable, where only one option from a group should be specified at a time. Unit tests coverage.
brbzull0
commented
Oct 28, 2025
| In this case, `subinit` is the subcommand of `init` and `--initoption` is a switch of command `remove`. | ||
|
|
||
| Mutually Exclusive Groups |
|
[approve ci autest] |
cmcfarlen
requested changes
Nov 4, 2025
include/tscore/ArgParser.h
Outdated
| static void set_test_mode(bool test = true); | ||
|
|
||
| // When true, do_exit() throws instead of calling exit() | ||
| static thread_local bool _test_mode; |
There was a problem hiding this comment.
Does this need to be thread_local? Could it not just be a member variable on this instance?
There was a problem hiding this comment.
I was under the impression that catch2 can run tests in parallel, was trying to prevent that, but looking around seems it's not(in this case at least). I'll remove the thread_local.
Also, I thought about as member of ArgParser, but then I would need to pass an instance(ptr) of ArgParser to the Command class as most(if not all) of the do_exit calls are made from that(Command) class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for mutually exclusive option groups in ArgParser, allowing options that cannot be used together to be properly validated and documented.
This feature is useful for conflicting options like
--verbose/--quietor--enable/--disable, where only one option from a group should be specified at a time.fixes #12605