records: Accept const char* in RecSetRecordString to avoid const_cast.
#12629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the type safety of the RecSetRecordString function by changing its parameter type from const RecString to RecStringConst (both are const char * but using the more semantically appropriate type alias).
- Changed function signature to use
RecStringConstinstead ofconst RecStringfor better type clarity - Moved the
const_castfrom caller code into the implementation - Simplified caller code by removing the need for explicit
const_cast
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| include/records/RecCore.h | Updated function declaration to use RecStringConst parameter type |
| src/records/P_RecCore.cc | Updated function definition and added internal const_cast when assigning to union |
| src/mgmt/rpc/handlers/config/Configuration.cc | Removed unnecessary const_cast from caller now that function accepts const strings directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cmcfarlen
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't like how the cast was used in the caller, so now the cast is hidden in one place (implementation detail).
API changed but it's just internal .