Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #430: Resolving type system imports through sp is slows things down too much #433

Draft
wants to merge 12 commits into
base: release/3.6.x
Choose a base branch
from

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 20, 2024

What's in the PR

  • Clean up ClassLoaderUtils a bit
  • Added missing since version to deprecation
  • Consolidate redundant code inside RelativePathResolver_impl
  • Allow UimaBndPlugin to dive into transitive imports and process them as well
  • Make transitive import resoving optional
  • Added more debug logging

How to test manually

  • See issue description

Automatic testing

  • PR adds/updates unit tests

Documentation

  • PR adds/updates documentation

Organizational

  • PR adds/updates dependencies.
    Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.

…own too much

- Clean up ClassLoaderUtils a bit
- Added missing since version to deprecation
- Consolidate redundant code inside RelativePathResolver_impl
…own too much

- Allow UimaBndPlugin to dive into transitive imports and process them as well
…own too much

- Make transitive import resoving optional
- Added more debug logging
…em-imports-through-SPIs-slows-things-down-too-much

* release/3.6.x:
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
@reckart reckart added this to the 3.6.1 milestone Dec 20, 2024
@reckart reckart self-assigned this Dec 20, 2024
- Introduce thread-local cache in ImportResolver
- Fix leak between multi-threading tests
- Bit of cleaning up
- Try short-cutting the check if a URL target exists by handling file URLs directly via the file system and not opening a stream
- Try reducing the cases where unnecessary URLs are created because they can be expensive to create
- Improve some documentation
- Minor cleaning up
- Introduce a cache for services loaded per classloader to avoid expensive repeated loading of services via a ServiceLoader
- Introduce a cache for services loaded per classloader to avoid expensive repeated loading of services via a ServiceLoader
- Added method to clear the service cache
…em-imports-through-SPIs-slows-things-down-too-much

* release/3.6.x:
  Issue #431: Issue using SPI-enabled type systems embedded into PEARs
…into refactoring/430-Resolving-type-system-imports-through-SPIs-slows-things-down-too-much

* refactoring/435-Improve-performance-of-ImportResolver:
  Issue #435: Improve performance of ImportResolver
  Issue #435: Improve performance of ImportResolver
  Issue #435: Improve performance of ImportResolver
  Issue #435: Improve performance of ImportResolver
  Issue #435: Improve performance of ImportResolver
  Issue #435: Improve performance of ImportResolver

% Conflicts:
%	uimaj-core/src/main/java/org/apache/uima/resource/impl/RelativePathResolver_impl.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant