-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #430: Resolving type system imports through sp is slows things down too much #433
Draft
reckart
wants to merge
12
commits into
release/3.6.x
Choose a base branch
from
refactoring/430-Resolving-type-system-imports-through-SPIs-slows-things-down-too-much
base: release/3.6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own too much - Clean up ClassLoaderUtils a bit - Added missing since version to deprecation - Consolidate redundant code inside RelativePathResolver_impl
…own too much - Allow UimaBndPlugin to dive into transitive imports and process them as well
…own too much - Make transitive import resoving optional - Added more debug logging
…em-imports-through-SPIs-slows-things-down-too-much * release/3.6.x: Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs Issue #431: Issue using SPI-enabled type systems embedded into PEARs
- Introduce thread-local cache in ImportResolver - Fix leak between multi-threading tests - Bit of cleaning up
- Try short-cutting the check if a URL target exists by handling file URLs directly via the file system and not opening a stream
- Try reducing the cases where unnecessary URLs are created because they can be expensive to create - Improve some documentation - Minor cleaning up
- Introduce a cache for services loaded per classloader to avoid expensive repeated loading of services via a ServiceLoader
- Introduce a cache for services loaded per classloader to avoid expensive repeated loading of services via a ServiceLoader
- Added method to clear the service cache
…em-imports-through-SPIs-slows-things-down-too-much * release/3.6.x: Issue #431: Issue using SPI-enabled type systems embedded into PEARs
…into refactoring/430-Resolving-type-system-imports-through-SPIs-slows-things-down-too-much * refactoring/435-Improve-performance-of-ImportResolver: Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver Issue #435: Improve performance of ImportResolver % Conflicts: % uimaj-core/src/main/java/org/apache/uima/resource/impl/RelativePathResolver_impl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation
Organizational
Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.