Issue #435: improve performance of import resolver #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce thread-local cache in ImportResolver - Fix leak between multi-threading tests - Bit of cleaning up
- Try short-cutting the check if a URL target exists by handling file URLs directly via the file system and not opening a stream
- Try reducing the cases where unnecessary URLs are created because they can be expensive to create - Improve some documentation - Minor cleaning up
- Introduce a cache for services loaded per classloader to avoid expensive repeated loading of services via a ServiceLoader
- Introduce a cache for services loaded per classloader to avoid expensive repeated loading of services via a ServiceLoader
- Added method to clear the service cache
- Added build action from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation
Organizational
Only dependencies under approved licenses are allowed. LICENSE and NOTICE files in the respective modules where dependencies have been added as well as in the project root have been updated.