[WICKET-7173] JavaxWebSocketConfigurator: Add back null check for httpSession#1356
Merged
martin-g merged 1 commit intoapache:masterfrom Jan 23, 2026
Merged
[WICKET-7173] JavaxWebSocketConfigurator: Add back null check for httpSession#1356martin-g merged 1 commit intoapache:masterfrom
martin-g merged 1 commit intoapache:masterfrom
Conversation
…pSession Changes for WICKET-7162 removed a null check, leading to another NPE when trying to add httpSession to the userProperties map
4590a9a to
8756fa6
Compare
martin-g
approved these changes
Jan 23, 2026
Member
|
Thank you, @weber-semedy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for WICKET-7162 (#1223) removed a null check for
httpSession, leading to another NPE when trying to addhttpSessionto theuserPropertiesmapI requested a Jira account to file a new issue and retrieve the id.The id is now added.NOTE:
We will still see the approproriate (follow-up) exception when
httpSessionisnull: