Skip to content

[ZEPPELIN-6181] fix can't login with plus char as password #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sh1nj1
Copy link
Contributor

@sh1nj1 sh1nj1 commented Apr 29, 2025

What is this PR for?

This PR fixes an issue where usernames or passwords containing a "+" character were being incorrectly converted to a " "(space), preventing users from signing in with password containing "+" character

What type of PR is it?

Bug Fix

Todos

What is the Jira issue?

How should this be tested?

  • Add account using password containing "+" character in shiro.ini
  • Test if it can do login successfully

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@sh1nj1 sh1nj1 changed the title [Zeppelin-6181] fix can't login with plus char as password [ZEPPELIN-6181] fix can't login with plus char as password Apr 29, 2025
@Reamer Reamer requested a review from jongyoul April 29, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant