-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[ZEPPELIN-6188] Improve Elasticsearch interpreter config and help message #4929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[ZEPPELIN-6188] Improve Elasticsearch interpreter config and help message #4929
Conversation
With the change of the default port to 9200 and the client type there is a breaking change in my opinion. |
@Reamer The reason for changing the default port to Since the We should document this clearly in the release notes and, if possible, provide migration guidance for users still on older versions. |
Can you please adjust the pull request description. |
@Reamer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParkGyeongTae
Checkstyle fails, please adjust the line.
[INFO] There is 1 error reported by Checkstyle 9.3 with zeppelin/checkstyle.xml ruleset.
Error: src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java:[88] (sizes) LineLength: Line is longer than 100 characters (found 103).
[INFO] ------------------------------------------------------------------------
@Reamer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for CI
What is this PR for?
The following improvements have been made to the Elasticsearch interpreter:
These changes enhance the usability of the interpreter and make it easier for users to configure and understand how to interact with Elasticsearch through Zeppelin.
What type of PR is it?
Refactoring
Todos
/elasticsearch/src/main/resources/interpreter-setting.json
file/elasticsearch/src/main/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreter.java
fileWhat is the Jira issue?
How should this be tested?
%elasticsearch help
Screenshots (if appropriate)
Questions: