-
Notifications
You must be signed in to change notification settings - Fork 2.8k
please add scala3 interpreter ,so important for storch deep learning framework and open the github issue dashborad #4930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@mullerhai Hello, thank you for your contribution to Apache Zeppelin. By the way, I think it's not a minor issue, so could you please create an issue first and fill out the description, including why you need a new Scala 3 interpreter, not extending Spark Interpreter? At the code level, you need to clean up commented code and add test cases for your implementation. Could you please check https://zeppelin.apache.org/contribution/contributions.html? It's a bit old document, but it helps you figure out the contribution |
HI, now we have scala version pytorch named storch is exhance all thing from cpp libtorch by javacpp, but the storch only support scala3 https://github.com/mullerhai/storch , now all spark interpreter in zeppelin only support scala 2.11 2.12 2.13, they are not suitable for storch ,so can not use spark interpreter to extend. we must support scala3 eagerly , scala 2.* is too old |
another querestion , does zeppelin 0.12.0 support jdk 24? , I meet error when do that ,syntax error @[1,1] |
No |
So the ask here is for a Scala interpreter that omits Spark? Spark does not support Scala 3. For Scala 3, there is https://scala-cli.virtuslab.org/ - an interpreter could be potentially built around that but the main need would be for a volunteer to take it on. |
<modelVersion>4.0.0</modelVersion> | ||
<properties> | ||
<!-- 设置 Scala 版本 --> | ||
<scala.version>3.6.4</scala.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not an LTS Scala release
|
||
|
||
<packaging>jar</packaging> | ||
<name>Zeppelin: Storch-Scala3 interpreter</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be possible to write a generic Scala interpreter into which Storch could be imported optionally? - a bit like how Scala CLI works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need scala3 notebook just like jupyter , please support
@mullerhai I'm not good at Scala 3 and storch, but the Zeppelin community is open for a new interpreter. Please feel free to suggest the new one to the dev@ and/or users@ to work together. |
thanks ,zeppelin is perfect tools, I have use for 8 years, zeppelin support data analysis, now Storch is powerful deep learning on scala3 , if zeppelin want to becomme scala-jupyter, please support scala3 and storch. I am not good at scala3 interpreter. just want to talk with you . I think your team need talk about this .thanks |
I raised sbrunk/storch#87 |
What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
What type of PR is it?
Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
Please leave your type of PR only
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: