Skip to content

Conversation

mullerhai
Copy link

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

What type of PR is it?

Bug Fix
Improvement
Feature
Documentation
Hot Fix
Refactoring
Please leave your type of PR only

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Strongly recommended: add automated unit tests for any new or changed behavior
  • Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@jongyoul
Copy link
Member

@mullerhai Hello, thank you for your contribution to Apache Zeppelin. By the way, I think it's not a minor issue, so could you please create an issue first and fill out the description, including why you need a new Scala 3 interpreter, not extending Spark Interpreter? At the code level, you need to clean up commented code and add test cases for your implementation. Could you please check https://zeppelin.apache.org/contribution/contributions.html? It's a bit old document, but it helps you figure out the contribution

@mullerhai
Copy link
Author

@mullerhai Hello, thank you for your contribution to Apache Zeppelin. By the way, I think it's not a minor issue, so could you please create an issue first and fill out the description, including why you need a new Scala 3 interpreter, not extending Spark Interpreter? At the code level, you need to clean up commented code and add test cases for your implementation. Could you please check https://zeppelin.apache.org/contribution/contributions.html? It's a bit old document, but it helps you figure out the contribution

HI, now we have scala version pytorch named storch is exhance all thing from cpp libtorch by javacpp, but the storch only support scala3 https://github.com/mullerhai/storch , now all spark interpreter in zeppelin only support scala 2.11 2.12 2.13, they are not suitable for storch ,so can not use spark interpreter to extend.
now we want to use zeppelin for deep learning notebook as jupyter for python . but zeppelin only support scala 2.* ,

we must support scala3 eagerly , scala 2.* is too old
by the way , we must open the issue dashboard for everyone to make issue for you team so you could listen what the user care about

@mullerhai
Copy link
Author

@mullerhai Hello, thank you for your contribution to Apache Zeppelin. By the way, I think it's not a minor issue, so could you please create an issue first and fill out the description, including why you need a new Scala 3 interpreter, not extending Spark Interpreter? At the code level, you need to clean up commented code and add test cases for your implementation. Could you please check https://zeppelin.apache.org/contribution/contributions.html? It's a bit old document, but it helps you figure out the contribution

another querestion , does zeppelin 0.12.0 support jdk 24? , I meet error when do that ,syntax error @[1,1]

@Reamer
Copy link
Contributor

Reamer commented May 22, 2025

does zeppelin 0.12.0 support jdk 24?

No

@pjfanning
Copy link
Contributor

So the ask here is for a Scala interpreter that omits Spark? Spark does not support Scala 3.

For Scala 3, there is https://scala-cli.virtuslab.org/ - an interpreter could be potentially built around that but the main need would be for a volunteer to take it on.

<modelVersion>4.0.0</modelVersion>
<properties>
<!-- 设置 Scala 版本 -->
<scala.version>3.6.4</scala.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an LTS Scala release



<packaging>jar</packaging>
<name>Zeppelin: Storch-Scala3 interpreter</name>
Copy link
Contributor

@pjfanning pjfanning Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to write a generic Scala interpreter into which Storch could be imported optionally? - a bit like how Scala CLI works.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need scala3 notebook just like jupyter , please support

@jongyoul
Copy link
Member

@mullerhai I'm not good at Scala 3 and storch, but the Zeppelin community is open for a new interpreter. Please feel free to suggest the new one to the dev@ and/or users@ to work together.

@mullerhai
Copy link
Author

@mullerhai I'm not good at Scala 3 and storch, but the Zeppelin community is open for a new interpreter. Please feel free to suggest the new one to the dev@ and/or users@ to work together.

thanks ,zeppelin is perfect tools, I have use for 8 years, zeppelin support data analysis, now Storch is powerful deep learning on scala3 , if zeppelin want to becomme scala-jupyter, please support scala3 and storch. I am not good at scala3 interpreter. just want to talk with you . I think your team need talk about this .thanks

@pjfanning
Copy link
Contributor

I raised sbrunk/storch#87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants