[ZEPPELIN-6269] Handle remove failures in NotebookRepoSync to prevent data inconsistency #5015
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
If an
IOException
occurs while trying to remove a note from one of the repositories, thefor
loop would terminate immediately. This leaves the note in an inconsistent state where it is deleted from some repositories but not from others, leading to data inconsistency.Approach
failedRepos
list.failedRepos
list. If the list is not empty, it throws a singleIOException
that includes information about all the repositories where the removal failed.What type of PR is it?
Refactoring
Todos
What is the Jira issue?
How should this be tested?
NotebookRepoSyncTest
.Screenshots (if appropriate)
Questions: