[fix] inverse ternary operator statements #7085
Conversation
| @@ -79,7 +79,7 @@ public function getResourceObjectType(ResourceMetadataCollection $resourceMetada | |||
|
|
|||
| if ('item_query' === $operationName || 'collection_query' === $operationName) { | |||
| // Test if the collection/item has different groups | |||
| if ($resourceMetadataCollection->getOperation($operation instanceof CollectionOperationInterface ? 'item_query' : 'collection_query')->getNormalizationContext() !== $operation->getNormalizationContext()) { | |||
| if ($resourceMetadataCollection->getOperation($operation instanceof CollectionOperationInterface ? 'collection_query' : 'item_query')->getNormalizationContext() !== $operation->getNormalizationContext()) { | |||
There was a problem hiding this comment.
this is wanted see above comment
There was a problem hiding this comment.
You mean this "Test if the collection/item has different groups" ? It's not very explicit.
Sorry for not explained with more details but I thought it was obvious to understand. If you don't inverse as I suggest you'll need to allow QueryCollection operation if you only set Query operation. Same for the inverse (Query operation only will need QueryCollection operation). That's because the ternary operator is wrong.
It's history for me as I fixed it locally but I get the message 'Operation "item_query" not found for resource "Project"' from #api-platform/api-platform#2434 which was my case.
There was a problem hiding this comment.
In API Platform if a collection operation, an item operation must exist. So probably that the correct fix for this would be to always create an empty item_query if we couldn't find any here.
Just a simple fix...
It could explain this maybe: api-platform/api-platform#2434