Add phpdoc for array of some interface #7583
Conversation
VincentLanglet
force-pushed
the
phpdoc
branch
from
c5c4ee5 to
919f0b0
Compare
phpstan.neon.dist
Outdated
| - src/State/Tests | ||
| - src/Symfony/Tests | ||
| - tests | ||
| - src # TODO |
There was a problem hiding this comment.
do we really want to add src here?
There was a problem hiding this comment.
There is currently 1500 errors of missingType.iterableValue so I cannot fix all of them
I thought it could be interesting that one day all the existing array from /src folder are described by a PHPdoc no? So currently src is ignored (which is already the case) and one day it won't. WDYT ?
VincentLanglet
force-pushed
the
phpdoc
branch
from
919f0b0 to
ecc4aa1
Compare
|
Friendly ping @soyuka, I'd like to work on improving the phpdoc. Can we move on this PR ? As shown by https://github.com/api-platform/core/actions/runs/20879513781/job/59993747689?pr=7583 there is ~1300 errors to solve, that's why I currently still ignore the src folder. (#7583 (comment)) But the plan would be for me to provide multiple PR fixing those errors and finally check src folder. The other solution would be to generate a baseline with those 1300 errors, if you prefer. |
2 participants
When using PHPStan, array are recommended to be typehinted.
When implementing interface from ApiPlatform, I get error because there are not described. It's kinda annoying having to add
array<mixed>while the phpdoc could be improved on ApiPlatform side.