Skip to content

Update serialization.md #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: 4.1
Choose a base branch
from
Open

Update serialization.md #1490

wants to merge 12 commits into from

Conversation

jzabrodin
Copy link
Contributor

@jzabrodin jzabrodin commented Dec 28, 2021 •
edited
Loading

Add few details about max_depth and enable_max_depth

@jzabrodin jzabrodin changed the title Patch 2 Update serialization.md Dec 28, 2021
@jzabrodin jzabrodin marked this pull request as ready for review December 28, 2021 11:07
dunglas
dunglas requested changes Dec 28, 2021
View reviewed changes
jzabrodin and others added 2 commits December 28, 2021 13:30
@jzabrodin @dunglas
Update core/serialization.md
17c170e 
Co-authored-by: Kévin Dunglas <[email protected]>
@jzabrodin @dunglas
Update core/serialization.md
5babbc7 
Co-authored-by: Kévin Dunglas <[email protected]>
@jzabrodin jzabrodin marked this pull request as draft December 28, 2021 11:34
@jzabrodin jzabrodin marked this pull request as ready for review December 28, 2021 11:50
@jzabrodin jzabrodin requested a review from dunglas December 28, 2021 19:14
vincentchalamon
vincentchalamon requested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide an XML example

vincentchalamon
vincentchalamon approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment from Dunglas to fix, then 👍

@jzabrodin @dunglas
Update core/serialization.md
cfce698 
Co-authored-by: Kévin Dunglas <[email protected]>
@vinceAmstoutz vinceAmstoutz changed the base branch from 2.6 to 3.4 January 14, 2025 10:46
vincentchalamon
vincentchalamon requested changes Jan 14, 2025
View reviewed changes
@vincentchalamon
Copy link
Contributor

I would suggest to target 4.0 branch instead of 3.4, WDYT @vinceAmstoutz @soyuka?

@vinceAmstoutz
Copy link
Member

I would suggest to target 4.0 branch instead of 3.4, WDYT @vinceAmstoutz @soyuka?

IMHO 3.4

@vinceAmstoutz vinceAmstoutz changed the base branch from 3.4 to 4.1 September 8, 2025 09:23
vinceAmstoutz
vinceAmstoutz approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzabrodin Could you please rebase with the 4.1 branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentchalamon vincentchalamon vincentchalamon requested changes

@vinceAmstoutz vinceAmstoutz vinceAmstoutz approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@soyuka soyuka Awaiting requested review from soyuka

@alanpoulain alanpoulain Awaiting requested review from alanpoulain

Assignees
No one assigned
Labels
Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jzabrodin @vincentchalamon @vinceAmstoutz @dunglas