Skip to content

Conversation

timble-one
Copy link

graphql-normalizer needs to be injected

@timble-one timble-one force-pushed the graphql-media-object-normalization branch from 99ecafc to 0c170e2 Compare December 14, 2024 14:44
Copy link
Member

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@71m024 Tanks for your contribution!

Can you please add more explanation on the “Why”?

Also, can you add an injection example for Laravel? As you can see here with an example of injection, we now document both Symfony and Laravel (since 4.0).

@vinceAmstoutz
Copy link
Member

@timble-one Do you plan to keep going?

@timble-one timble-one force-pushed the graphql-media-object-normalization branch from 0c170e2 to cc72224 Compare September 8, 2025 14:06
@timble-one
Copy link
Author

@vinceAmstoutz I made it i little bit clearer, that the injected normalizer must be replaced with the one from the graphql namespace. Otherwise it won't work if you just do it like it is done here: https://api-platform.com/docs/symfony/file-upload/
(this link is mentioned at the start of the chapter)

I have never used Laravel before. If this must be ported to the Laravel Documentation it should be done be someone who has experience.

@timble-one timble-one force-pushed the graphql-media-object-normalization branch from cc72224 to 2a9a455 Compare September 8, 2025 14:28
@timble-one
Copy link
Author

I think the linting Problem is not caused by this PR.

@vinceAmstoutz vinceAmstoutz changed the base branch from 4.0 to 4.1 September 9, 2025 08:43
@vinceAmstoutz
Copy link
Member

vinceAmstoutz commented Sep 9, 2025

I think the linting Problem is not caused by this PR.

@timble-one Yes you're right, could you please rebase it from the 4.1 branch?

@timble-one timble-one force-pushed the graphql-media-object-normalization branch from 2a9a455 to 196715a Compare September 9, 2025 13:40
graphql-normalizer needs to be injected
@timble-one timble-one force-pushed the graphql-media-object-normalization branch from 196715a to b0c9e2b Compare September 9, 2025 13:51
Copy link
Member

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be great for me after theses changes @timble-one

timble-one and others added 2 commits September 11, 2025 09:44
Copy link
Member

@vinceAmstoutz vinceAmstoutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @timble-one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants