-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
graphql.md: add "MediaObject Normalization" chapter #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.1
Are you sure you want to change the base?
graphql.md: add "MediaObject Normalization" chapter #2109
Conversation
99ecafc
to
0c170e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@71m024 Tanks for your contribution!
Can you please add more explanation on the “Why”?
Also, can you add an injection example for Laravel? As you can see here with an example of injection, we now document both Symfony and Laravel (since 4.0
).
@timble-one Do you plan to keep going? |
0c170e2
to
cc72224
Compare
@vinceAmstoutz I made it i little bit clearer, that the injected normalizer must be replaced with the one from the graphql namespace. Otherwise it won't work if you just do it like it is done here: https://api-platform.com/docs/symfony/file-upload/ I have never used Laravel before. If this must be ported to the Laravel Documentation it should be done be someone who has experience. |
cc72224
to
2a9a455
Compare
I think the linting Problem is not caused by this PR. |
@timble-one Yes you're right, could you please rebase it from the |
2a9a455
to
196715a
Compare
graphql-normalizer needs to be injected
196715a
to
b0c9e2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be great for me after theses changes @timble-one
optimization from @vinceAmstoutz Co-authored-by: Vincent Amstoutz <[email protected]>
optimization from @vinceAmstoutz Co-authored-by: Vincent Amstoutz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @timble-one!
graphql-normalizer needs to be injected