Skip to content

Amount schema value type is expected to be a number and not a string #1804

Description

@bbenligiray

This is how amounts are represented

{
  "unit": "ether",
  "value": 1
}

Since value may still be a big number, it should be represented as a string and not a number type.
For reference, ethers.utils.parseUnits(1, 'ether') throws and ethers.utils.parseUnits('1', 'ether') succeeds.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions