Skip to content

fix: defaultBuild() returns BuildClient #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 23, 2025
Merged

fix: defaultBuild() returns BuildClient #677

merged 3 commits into from
Apr 23, 2025

Conversation

danpoletaev
Copy link
Contributor

This PR updates the Actor.defaultBuild() method to return a BuildClient instance instead of a raw response object.

@danpoletaev danpoletaev added the adhoc Ad-hoc unplanned task added during the sprint. label Apr 22, 2025
@danpoletaev danpoletaev requested review from fnesveda and barjin April 22, 2025 12:18
@danpoletaev danpoletaev self-assigned this Apr 22, 2025
@github-actions github-actions bot added this to the 113th sprint - Platform team milestone Apr 22, 2025
@github-actions github-actions bot added t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. labels Apr 22, 2025
barjin
barjin approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo looking good, thank you!

@danpoletaev danpoletaev merged commit 8ce72a4 into master Apr 23, 2025
7 checks passed
@danpoletaev danpoletaev deleted the fix/default-build-return-client branch April 23, 2025 09:54
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnesveda fnesveda fnesveda approved these changes

@barjin barjin barjin approved these changes

Assignees

@danpoletaev danpoletaev

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
113th sprint - Platform team
Development

Successfully merging this pull request may close these issues.
3 participants
@danpoletaev @fnesveda @barjin