Skip to content

feat: allow sorting of Actors collection #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 18, 2025

Conversation

protoss70
Copy link
Contributor

Added new sorting param sortBy for the new feature described in this Issue

I will wait until Apify-Core PR is deployed and then will merge this.

@protoss70 protoss70 requested review from B4nan and tobice June 16, 2025 12:43
@protoss70 protoss70 added the t-integrations Issues with this label are in the ownership of the integrations team. label Jun 16, 2025
@B4nan B4nan changed the title Feature/new acts sorting param sort by feat: allow sorting of Actors collection Jun 16, 2025
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one note about the PR title (which applies to all the repositories, especially libraries), we follow conventional commits, so it should be in the form feat: ... where the ... will end up in the generated changelog - that part should be imperative and should describe what changed so users can understand it. Only feat/fix/perf commit types will end up in the changelog (plus any PR with states a breaking change in the PR description).

For this PR, I would go with something like feat: allow sorting of Actors collection or similar (I changed it already but feel free to improve it). The same applies to fixes, the commit type prefix is not part of this "sentence", so while it might look weird at first, using something like fix: fix this and that is the correct way, while fix: this and that is not.

@github-actions github-actions bot added the tested Temporary label used only programatically for some analytics. label Jun 18, 2025
@protoss70 protoss70 merged commit 562a193 into master Jun 18, 2025
7 checks passed
@protoss70 protoss70 deleted the feature/new-acts-sorting-param-sortBy branch June 18, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-integrations Issues with this label are in the ownership of the integrations team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants