feat(charging): Support the idempotency_key param in Actor.charge() - #1123
Open
Mantisus wants to merge 8 commits into
Open
feat(charging): Support the idempotency_key param in Actor.charge()#1123Mantisus wants to merge 8 commits into
idempotency_key param in Actor.charge()#1123Mantisus wants to merge 8 commits into
Conversation
Mantisus
changed the title
idempotency_key param in Actor.charge()
Mantisus
commented
Sep 11, 2026
Comment on lines
+511
to
+510
| # Only remember a key that stands for a charge the platform actually received. Off the platform there | ||
| # is no request at all and the registry is the only thing providing deduplication. | ||
| if idempotency_key is not None and (not self._is_at_home or charge_sent): | ||
| # Remember the key for every charge that was counted, including events the API never receives, such as | ||
| # synthetic and tier-priced ones - those are counted locally and a repeat would count them twice. | ||
| if idempotency_key is not None: |
Collaborator
Author
There was a problem hiding this comment.
With this update, the idempotency_key will be saved even for events that do not exist.
Collaborator
Author
|
@barjin, Please take a look at the implementation. In the TS SDK, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the
idempotency_keyparameter inActor.charge().Closes: #1122