fix: Resolve LogRecord attribute conflict in event manager logging#802
Merged
fix: Resolve LogRecord attribute conflict in event manager logging#802
Conversation
The `extra={'message': message}` in the exception handler overwrites
Python's built-in `LogRecord.message` attribute, corrupting the log
record and preventing caplog from capturing it (especially on 3.13+).
Renamed to `raw_message` to avoid the collision.
Also fixed `test_unknown_event_is_logged` which was missing an explicit
`caplog.set_level(logging.INFO)` — the unknown event is logged at INFO
level but caplog only captures WARNING+ by default.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
vdusek
added
adhoc
github-actions
bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 85.50% 85.54% +0.03%
==========================================
Files 46 46
Lines 2691 2691
==========================================
+ Hits 2301 2302 +1
+ Misses 390 389 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Feb 18, 2026
# Conflicts: # tests/unit/events/test_apify_event_manager.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra={'message': message}toextra={'raw_message': message}inApifyEventManager._process_platform_messages— themessagekey overwrites Python's built-inLogRecord.messageattribute, corrupting the log record (especially visible on Python 3.13+).caplog.set_level(logging.INFO, logger='apify')totest_unknown_event_is_logged— the unknown event is logged atINFOlevel butcaplogonly capturesWARNING+ by default, causing the assertion to always fail.Test plan
🤖 Generated with Claude Code