-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Introduce new storage clients #1107
Draft
vdusek
wants to merge
5
commits into
master
Choose a base branch
from
memory-storage-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,876
−3,465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pijukatel
reviewed
Mar 20, 2025
|
||
Args: | ||
kwargs: Keyword arguments for the storage client method. | ||
offset: Skips the specified number of items at the start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to explicitly say in what order some arguments take effect to avoid misinterpretations.
For example: offset + desc
- reverse and then offset
or - offset and then reverse?
1f433c8
to
ec32ec9
Compare
3336b2d
to
2a9a840
Compare
2a9a840
to
bdadd43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft version
Description
DatasetClient
,FileSystemDatasetClient
,MemoryDatasetClient
,Dataset
has been updated accordingly.Dataset
were removed and will be implemented in the specific storage clients instead.persist_storage
flag.storages/
module will be removed later.Suggested
Dataset
breaking changesstorage_object
→metadata
propertyget_info
→metadata
propertyset_metadata
method has been removed - Do we want to support it (e.g. for renaming)?from_storage_object
method has been removed - Use theopen
method withname
and/orid
instead.check_and_serialize
method has been removed - The clients should handle serialization.iterate_items
→iterate
methodSuggested
KeyValueStore
breaking changesstorage_object
→metadata
propertyget_info
→metadata
propertyset_metadata
method has been removed - Do we want to support it (e.g. for renaming)?from_storage_object
method has been removed - Use theopen
method withname
and/orid
instead.persist_autosaved_values
- It should be managed by the underlying client.get_auto_saved_value
- It should be managed by the underlying client.Issues
MemoryStorageClient
andFilesystemStorageClient
#92creation_management
module #147Dataset usage example
KVS usage example
Testing
Checklist