-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Introduce new storage clients #1107
base: master
Are you sure you want to change the base?
Conversation
invalid = [arg for arg in unsupported_args if arg not in (False, None)] | ||
if invalid: | ||
logger.warning( | ||
f'The arguments {invalid} of iterate_items are not supported by the {self.__class__.__name__} client.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f'The arguments {invalid} of get_data ...
|
||
Args: | ||
kwargs: Keyword arguments for the storage client method. | ||
offset: Skips the specified number of items at the start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to explicitly say in what order some arguments take effect to avoid misinterpretations.
For example: offset + desc
- reverse and then offset
or - offset and then reverse?
1f433c8
to
ec32ec9
Compare
Draft version
Description
DatasetClient
,FileSystemDatasetClient
,MemoryDatasetClient
,Dataset
has been updated accordingly.Dataset
were removed and will be implemented in the specific storage clients instead.persist_storage
flag.storages/
module will be removed later.Suggested
Dataset
breaking changesiterate_items
→iterate
methodstorage_object
→metadata
propertyget_info
→metadata
propertycheck_and_serialize
method has been removed - The clients should handle serialization.from_storage_object
method has been removed - Use theopen
method withname
and/orid
instead.set_metadata
method has been removed - Do we want to support it (e.g. for renaming)?Issues
MemoryStorageClient
andFilesystemStorageClient
#92creation_management
module #147Todo
StorageClient
,file_system_storage_client
,memory_storage_client
.Usage example
Testing
Checklist