refactor!: Split BrowserType literal into two different literals based on context
#1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two similar, but different contexts are `Playwright` and browser fingerprints
github-actions
bot
added
t-tooling
|
This is slightly breaking change, so probably wait until more braking changes accumulate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split
BrowserTypeliteral into two different literals based on context.This avoids some confusion and some implicit string manipulation in favor of explicit name mapping between the two different literals.
In Playwright:
'chromium', 'firefox', 'webkit'In browser fingerprints context it is :
'chrome', 'firefox', 'safari', 'edge'