chore: Add templates apify integration tests #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Adapt it to paltform environment. Generalize.
TODO: Test in github
Pijukatel
added
t-tooling
vdusek
reviewed
Mar 20, 2025
pyproject.toml
Outdated
Comment on lines
214
to
216
| exclude = ["project_template"] | ||
| files = ["src", "tests", "docs", "website"] | ||
| exclude = ["src/crawlee/project_template"] | ||
| modules=["crawlee", "tests"] |
There was a problem hiding this comment.
The exclude was done more specific to not exclude test/integration/project_template
The other line was not correct.
github-actions
bot
added
the
tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
crawleetemplates integration tests withApifyplatform. (onlyParselandBeautifulsouptemplates)Add workflow for manual triggering of integration tests (Will become automatic once it is running for a while to prove stability.)
Issues
Testing
Tested on forked repo:
https://github.com/Pijukatel/crawlee-python/actions/runs/13969844251
uvrelated part of the dockerfile):https://github.com/Pijukatel/crawlee-python/actions/runs/13970390933
parselactor template):https://github.com/Pijukatel/crawlee-python/actions/runs/13970267119
Next steps
Add tests for
Playwrightbased templates.Fix current problems with
Playwrighttemplate that has failing run in default settings.Making the integration tests each run in separate job. Each test can take long time and can be unstable due to the network issues. This brings the necessity to have the possibility to re-trigger individual tests and not the whole test suite.
Since Playwright based crawlers are slower, this will be introduced together with their testing.
Example such run, where only one template test can be re-triggered: