Refactor initialization of storages & memory resource clients#143
Merged
Refactor initialization of storages & memory resource clients#143
Conversation
github-actions
bot
added
the
t-tooling
janbuchar
reviewed
May 9, 2024
vdusek
force-pushed
the
rm-base-resource-clients
branch
from
f091771 to
554ab4d
Compare
janbuchar
reviewed
May 10, 2024
janbuchar
reviewed
May 10, 2024
janbuchar
approved these changes
May 10, 2024
Collaborator
janbuchar
left a comment
janbuchar
left a comment
There was a problem hiding this comment.
resolve my comments in any way you like, then feel free to merge 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BaseStorageandBaseResourceClientsare only ABC with abstract methods; all the creation-related code is moved to a separate module._creation_management.pyhelper modules in bothstorages/andmemory_storage_client/.crawlee/storages/models.pytocrawlee/models.pybecause of the import loops, I merged it withrequest.py. I am open to other ideas in this regard.Related issues
Testing