Skip to content

fix: include sql_mysql in the all extra#1895

Merged
vdusek merged 1 commit into
masterfrom
fix/add-sql-mysql-to-all-extra
May 13, 2026
Merged

fix: include sql_mysql in the all extra#1895
vdusek merged 1 commit into
masterfrom
fix/add-sql-mysql-to-all-extra

Conversation

@vdusek
Copy link
Copy Markdown
Collaborator

@vdusek vdusek commented May 13, 2026

Summary

The all meta-extra was missing sql_mysql, so installing crawlee[all] did not pull in the MySQL storage client dependencies (aiomysql, cryptography). This adds it alongside the other SQL extras.

The `all` meta-extra was missing `sql_mysql`, so installing `crawlee[all]` did not pull in the MySQL storage client dependencies.
@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels May 13, 2026
@vdusek vdusek self-assigned this May 13, 2026
@vdusek vdusek requested a review from Mantisus May 13, 2026 13:11
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.83%. Comparing base (0c89b6e) to head (1063542).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
- Coverage   92.87%   92.83%   -0.04%     
==========================================
  Files         167      167              
  Lines       11699    11699              
==========================================
- Hits        10865    10861       -4     
- Misses        834      838       +4     
Flag Coverage Δ
unit 92.83% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@vdusek vdusek merged commit 4023314 into master May 13, 2026
32 checks passed
@vdusek vdusek deleted the fix/add-sql-mysql-to-all-extra branch May 13, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants