Skip to content

Fix: Frontend CI Failing #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Conversation

NEStock
Copy link
Member

@NEStock NEStock commented May 19, 2025

No description provided.

@NEStock NEStock self-assigned this May 19, 2025
@NEStock NEStock linked an issue May 19, 2025 that may be closed by this pull request
Copy link

netlify bot commented May 19, 2025

Deploy Preview for ember-dandi-archive ready!

Name Link
🔨 Latest commit 7ea00c1
🔍 Latest deploy log https://app.netlify.com/projects/ember-dandi-archive/deploys/682c95dd6d18cf00088aebee
😎 Deploy Preview https://deploy-preview-74--ember-dandi-archive.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@NEStock
Copy link
Member Author

NEStock commented May 19, 2025

@yarikoptic RE: dandi#2388

I think Frontend CI is working here! need to fix the dandi-cli tests now

@yarikoptic
Copy link

oh, sweet, so the frontend fix should address

as for dandi-cli -- it is our unfortunate too tight "binding" between dandi-schema version and other components... ideally, we should just finish up

i.e. boost the version of dandi-schema, but I am not brave enough without more testing ;)

@NEStock NEStock marked this pull request as ready for review May 20, 2025 13:05
@NEStock
Copy link
Member Author

NEStock commented May 20, 2025

oh, sweet, so the frontend fix should address

@yarikoptic Yes! Opened a PR on dandi here: dandi#2389

@NEStock NEStock requested review from sandyhider and laurendiaz May 20, 2025 14:41
@NEStock NEStock merged commit 527b818 into apl-setup May 20, 2025
11 of 13 checks passed
@sandyhider sandyhider deleted the 73-ci-for-frontend-tests-failing branch May 20, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"CI for frontend" tests failing
3 participants