Add CommonJs Support (SyntaxError: Unexpected token 'export') #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dchambers: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Strange. We have react native example that build fine: https://github.com/apollographql/apollo-cache-persist/blob/master/examples/react-native/App.tsx#L14 (Web example uses source code import. |
wtrocki
reviewed
Oct 12, 2020
| @@ -20,7 +20,7 @@ | |||
| "bugs": "https://github.com/apollographql/apollo-cache-persist/issues", | |||
| "scripts": { | |||
| "build:browser": "browserify ./lib/bundle.umd.js -o=./lib/bundle.js && npm run minify:browser", | |||
| "build": "tsc -p .", | |||
| "build": "tsc -p . && tsc -p ./tsconfig.cjs.json", | |||
There was a problem hiding this comment.
Are we going to compile twice with duplicate source code?
|
Going to merge this and release now. |
Thanks so much for the speedy response here @wtrocki! 🙏 |
|
Thank you for reminding me to release it |
|
Hi @wtrocki, any chance I can get you to release this when you get a moment? |
|
Doing that now! |
|
Thanks @wtrocki 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
apollo3-cache-persistmodule exported to npm is not CommonJS compatible at present, resulting in aSyntaxError: Unexpected token 'export'for me in Next.js.The
tsconfig.jsonfile hasmoduleset toes2015, and this is presumably since Rollup (used to create a UMD module for the non-npm browser case) needs ES6 modules for tree-shaking to work. This change creates a fall-back CommonJS export (withinlib/cjs) for any tooling that does not support themodulekey (also aliased asjsnext:main) inpackage.json.