-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OTel to 0.24 to support Hyper 1 #6493
Conversation
…ions compatible with 0.24. Mostly done, pending Jaeger changes.
…pted to switch Jaeger integration tests to use OTLP, and replaced deprecated i64_histogram with u64_histogram.
…nd fixed some tests. Trace integration tests still need updates due to change in span data.
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removed
Build ID: 4c6bf22bb5200b76ef845054 URL: https://www.apollographql.com/docs/deploy-preview/4c6bf22bb5200b76ef845054 |
CI performance tests
|
…now merges resource template attributes into the spans attributes.
…ing resource attributes into all spans.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from a Connectors point of view, as the changes there seem minor.
For the Jaeger breaking change, can you update the CHANGELOG.md? It doesn't seem like there'd be a way to automatically migrate existing config?
The opentelemetry crate began supporting hyper 1 at version 0.24. At 0.25, the openetelemetry folks started publishing all the related packages in lockstep with the main crate, but they also made some significant breaking changes which will require a large rewrite of our wrappers. I've stuck with 0.24 instead of going all the way to the latest 0.27 to minimize the changes in this particular upgrade.
The main breaking changes are:
u64_histogram
instead.The smaller changes are:
Unit
struct is replaced with opaqueCow<'static, str>
SpanData
no longer contains aResource
, so we need to add that data separately prior to export and implementset_resource
for wrappers onSpanExporter
andSpanProcessor
Vec<KeyValue>
instead ofOrderMap
orEvictedHashMap
LightSpanData
wrapper replaced the latter withHashMap
to deduplicate attributes prior to exportChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩