Skip to content

NO-JIRA: Updating CI base image to support Golang with 1.24 #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BaiyangZhou
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Collaborator

@BaiyangZhou: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ncaak and opokornyy June 18, 2025 03:28
@BaiyangZhou BaiyangZhou changed the title NO-JIRA: Updating CI base image to support Golang with 1.24+ NO-JIRA: Updating CI base image to support Golang with 1.23.9 Jun 18, 2025
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BaiyangZhou, ncaak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BaiyangZhou
Copy link
Contributor Author

/retest

Copy link
Contributor

red-hat-konflux bot commented Jun 24, 2025

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
staging-mirror-set no kind "ImageDigestMirrorSet" is registered for version "config.openshift.io/v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"
prod-mirror-set no kind "ImageDigestMirrorSet" is registered for version "config.openshift.io/v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

@BaiyangZhou
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Jun 25, 2025

New changes are detected. LGTM label has been removed.

@BaiyangZhou BaiyangZhou changed the title NO-JIRA: Updating CI base image to support Golang with 1.23.9 NO-JIRA: Updating CI base image to support Golang with 1.24 Jun 25, 2025
Copy link

openshift-ci bot commented Jun 25, 2025

@BaiyangZhou: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deployment-validation-operator-e2e-tests b4db781 link true /test deployment-validation-operator-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (d340aa6) to head (b4db781).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   46.16%   46.16%           
=======================================
  Files          22       22           
  Lines        1083     1083           
=======================================
  Hits          500      500           
  Misses        553      553           
  Partials       30       30           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants