datafile field is necessary if change type is used later. #199
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveteahan
reviewed
Mar 23, 2023
| @@ -15,7 +15,7 @@ Now, we will take a look at each attribute associated with a GraphQL type. | |||
|
|
|||
| `fields`: This is a list of all fields associated with a type. The fields themselves adhere to specific [json-schema](https://github.com/app-sre/qontract-schemas/blob/main/schemas/app-interface/graphql-schemas-1.yml) that we will explore later in this document. | |||
|
|
|||
| `datafile`: This attribute does not seem to be in used currently. | |||
| `datafile`: This is necessary for [App Interface change type](https://gitlab.cee.redhat.com/service/app-interface/-/blob/master/docs/app-sre/change-types.md). | |||
There was a problem hiding this comment.
What about linking to the change types schema or something that isn't an internal url?
There was a problem hiding this comment.
Would it be possible to create description that is more generic and not specifically focused on the use-case?
Change-type is a feature that is implemented in qontract-reconcile and qontract-server should not be aware of features outside of its boundaries. We could very well have other features in q-r that make use of this functionality in future.
There was a problem hiding this comment.
this is not related to change-types but to the interfaceResolve strategy schema
|
@geoberle Could you give some background information about why this is the case please? |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted: https://github.com/OliviaHY/qontract-server/blob/0451a729312a8c877a4b9f1eeceafeab91fe2181/SCHEMA.md