[codex] Refresh control room and addon workflows#1
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe pull request reorganizes the Go application entrypoint into Changes
Sequence DiagramsequenceDiagram
participant App as Control Room App
participant FileSystem as File System
participant Manifest as Addon Manifest
participant Parser as JSON Parser
participant UI as UI Renderer
App->>FileSystem: Scan Addons/*/addon.json
FileSystem-->>App: Return manifest paths
loop For each manifest file
App->>Manifest: Read addon.json
Manifest-->>App: Raw JSON content
App->>Parser: Parse JSON into addonManifest
alt Valid JSON
Parser-->>App: addonManifest struct
App->>App: Expand ${repo_dir}, ${addon_dir}<br/>placeholders
App->>App: Validate actions & workDir
App->>App: Generate action entries with<br/>category & metadata
else Invalid/Malformed
Parser-->>App: Error + warning
App->>App: Skip manifest, log<br/>warning to control.log
end
end
App->>App: Build categories from all<br/>loaded actions
App->>UI: Render action panel with<br/>addon-provided actions
UI-->>App: User selects action
App->>FileSystem: Execute action command<br/>in addon workDir
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/tmodloader-ui, move app/backend code intointernal/controlroom, remove legacy interactive-shell fallback paths, and keep the shell hub focused on automation and direct command entrypoints.Addons/*/addon.json, clearer addon troubleshooting, cleaner command output, and better status/snapshot behavior..gitignoreall match the current self-contained layout and feature set.Validation
bash -nchecks run for touched scriptsAlso ran:
go test ./...go build ./...groff -man -Tutf8 man/tmod-control.1git diff --checkNotes
make tui-runormake tui-buildas needed, and place addon manifests underAddons/<name>/addon.json.Summary by CodeRabbit
New Features
Changed
Error,OK,Warning,Info).Documentation
CHANGELOG.mdin Keep-a-Changelog format.Bug Fixes
Tests