Repository navigation
ADFA-4886: Material 3 nav bar for the WebView chrome (icons, theme, a11y, i18n) - #270
Merged
Merged
Conversation
…11y, i18n) Replace the PortalActivity nav bar's emoji/glyph buttons with tinted Material 3 vector ImageButtons (back, fullscreen, reload/stop, exit, forward, plus the show/hide handles) and move PortalActivity onto Theme.K2Go (Material3 DayNight + app typography) so the chrome follows the system light/dark. Surfaces and tints come from theme attributes; Exit keeps its universal red. Add contentDescription to the icon-only buttons and move the WebView error-page strings into resources. Strings are translatable=false pending the l10n pass.
Make the recovery handle read as the nav bar's own surface peeking from the bottom edge instead of a separate button: a colorSurfaceContainer tab with rounded top corners and 8dp elevation (matching the bar), carrying a drag grabber tinted colorOnSurfaceVariant. Drops the now-unused ic_expand_less.
24dp was below the 48dp minimum touch target. Draw the visible tab only in the bottom strip (layer-list top inset) so the handle can be a full 48dp-tall, accessible touch target while keeping the slim peeking-tab look; the grabber stays centered in the visible portion via top padding.
androidx.appcompat's UseAppTint lint (a blocking error here) requires app:tint over android:tint on AppCompat image views. Switch all seven nav-bar ImageButton tints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Themes the
PortalActivityWebView chrome to Material 3.The nav bar's emoji/glyph buttons become tinted Material 3 vector
ImageButtons (back, fullscreen, reload/stop, exit, forward, plus the show/hide handles), andPortalActivitymoves ontoTheme.K2Go(Material3 DayNight + app typography), so the chrome follows the system light/dark. Surfaces and tints come from theme attributes; Exit keeps its universal red. AddscontentDescriptionto the icon-only buttons (updated on the reload↔stop toggle) and moves the WebView error-page strings ("Connection Failed", "Unable to reach the secure environment") into resources.New strings are
translatable="false"pending the l10n pass. App-side only; nav behavior (auto-hide / Home→Fullscreen) stays as merged in #268. Verify on-device.