Repository navigation
K2GO-434 refactor(setup): extract the detail host and action bar - #603
Merged
Merged
Conversation
Move opening a row's detail over the index, the detail action bar, and the detail state out of SetupProgressActivity into SetupDetailHost. The Activity keeps the actions that need its pipeline or context (retry the seed, cancel a module); the host fires them through a narrow Host. Behavior-preserving.
Name the SetupDetailHost.Host.goHome parameter clearSessions, matching the value it forwards to Activity.goHome (the old keepSessionsAlive name read as the opposite of its effect). Drop the dead detailBackBtn null check in configureDetailBar (the field is final and set in the constructor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the per-stream detail host out of SetupProgressActivity into a new
Activity-scoped SetupDetailHost, continuing the K2GO-434 decomposition.
Moved: opening a row's detail fragment over the index, the two-button detail
action bar (Back / Run in background, or Retry / Cancel for a module or seed),
the return to the index, and the detail state. The Activity keeps the actions
that need its pipeline or context (retry the seed, cancel a module); the host
fires them through a narrow Host interface. SetupProgressActivity drops ~144
lines.
Behavior-preserving: fragment transactions keep commitNow and the listener
reclaim order. Build plus 35 setup.domain unit tests green; two-pass review
done; device-smoked on a OnePlus (open detail, action bar, back to the index
with the row updating to Done, no crash).