-
Notifications
You must be signed in to change notification settings - Fork 159
Create unpacker protocol + ext4 unpacker #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
guard let unpackPath else { | ||
return | ||
} | ||
guard !FileManager.default.fileExists(atPath: unpackPath) else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also returns true if the path is a directory, do we still want to error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the wording to say that --unpack-path
should be a new directory and updated the error to match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :)
Signed-off-by: Aditya Ramani <[email protected]>
Signed-off-by: Aditya Ramani <[email protected]>
Signed-off-by: Aditya Ramani <[email protected]>
Creates a new Unpacker protocol that defines a single method
This change also removes the
unpack(...)
method from the Image type.Before
After