Skip to content

[release-7.3] Clip read-ahead cache reads to file size for small/last blocks #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akankshamahajan15 merged 1 commit into from
May 30, 2026
+3 −1
Merged

[release-7.3] Clip read-ahead cache reads to file size for small/last blocks #13293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion fdbrpc/include/fdbrpc/AsyncFileReadAhead.actor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ class AsyncFileReadAheadCache final : public IAsyncFile, public ReferenceCounted
// If not found, start the read.
if (i == f->m_blocks.end() || (i->second.isValid() && i->second.isError())) {
// printf("starting read of %s block %d\n", f->getFilename().c_str(), blockNum);
fblock = readBlock(f.getPtr(), f->m_block_size, (int64_t)f->m_block_size * blockNum);
int64_t blockStart = (int64_t)blockNum * f->m_block_size;
int readLength = std::min<int64_t>(f->m_block_size, fileSize - blockStart);
fblock = readBlock(f.getPtr(), readLength, blockStart);
f->m_blocks[blockNum] = fblock;
} else
fblock = i->second;
Expand Down