-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please review the library , all the mentioned reviews have been resolved #3
base: main
Are you sure you want to change the base?
Conversation
…nd comments have been resolved as well"
changes done in main.yaml
|
README.md
Outdated
# SmartBikeDesign | ||
|
||
|
||
UI library created using hml , CSS and JS for **HarmonyOS Project** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change string HarmonyOS to OpenHarmony
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please take ReadMe content from Vishnu
@@ -0,0 +1,16 @@ | |||
package com.example.smartbikedesign; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add copyright details in all new JS and Java files
entry/build.gradle
Outdated
ohosTestImplementation 'com.huawei.ohos.testkit:runner:1.0.0.100' | ||
} | ||
decc { | ||
supportType = ['html','xml'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove node_modules folder inside entry
@@ -0,0 +1,9 @@ | |||
{ | |||
"strings": { | |||
"hello": "Hello", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the unused strings
@@ -0,0 +1,11 @@ | |||
[ | |||
|
|||
{ "speedValue":"56", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format all the code file
Open file and do Ctrl + Alt + L to format
}else{ | ||
this.menu="/common/images/bottom/menu.png"; | ||
|
||
// console.info('Inside else condition of lowbeamonclick()'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the commented code
@@ -0,0 +1,8 @@ | |||
{ | |||
"strings": { | |||
"hello": "您好", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check the comments
No description provided.