Skip to content

fix(build): Show logs when build fails in prebuild phases #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(build): Show logs when build fails in prebuild phases #97

wants to merge 1 commit into from

Conversation

@blsmth
Copy link
Contributor

@blsmth blsmth commented Jul 22, 2025

Summary

Changes

  • Modified watchBuildPhase() in cmd/build.go to detect prebuild phase failures
  • When build state indicates failure during prebuild, stops spinner and streams logs
  • Preserves existing UX for successful builds (spinner only)
  • Supports both CloudWatch and S3 log sources

Test plan

  • Verify compilation and tests pass
  • Test with a build that fails during prebuild phase (malformed app.json)
  • Verify normal build flow still works correctly
  • Check that appropriate error logs are displayed

@blsmth
fix(build): Show logs when build fails in prebuild phases
76587bd 
Fixes #95. When builds fail during prebuild phases (INSTALL, PRE_BUILD, etc.),
users now see the relevant error logs instead of just a spinner. This helps
users understand failures like malformed app.json or apppack.toml files.

The implementation checks CodeBuild status (FAILED, STOPPED, TIMED_OUT) during
prebuild phases and streams logs when failures are detected. This preserves
existing UX for successful builds while providing error visibility for failures.
@blsmth blsmth force-pushed the show-prebuild-logs branch from 552831a to 76587bd Compare July 22, 2025 02:43
@blsmth
Copy link
Contributor Author

blsmth commented Jul 30, 2025

closing this one in favor of #98 which is the same thing but with a refactor to reduce complexity

@blsmth blsmth closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show logs when a build fails before the "build" phase starts

2 participants

@blsmth