Update: cleanups, improvements #1966
Open
+355
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment failed. 🔴 Last updated at: 2025-06-03 07:26:31 CET |
|
The preview deployment failed. 🔴 Last updated at: 2025-06-03 07:26:30 CET |
ItzNotABug
commented
Jun 2, 2025
src/routes/(console)/project-[region]-[project]/functions/templates/+page.ts
Outdated
Show resolved
Hide resolved
src/routes/(console)/project-[region]-[project]/functions/templates/+page.ts
Outdated
Show resolved
Hide resolved
src/routes/(console)/project-[region]-[project]/overview/+page.ts
Outdated
Show resolved
Hide resolved
|
TODO: load region based console variable early rather than per project. |
| for (const project of projects) { | ||
| project.region ??= 'default'; | ||
| } | ||
| sdk.forConsole.console.variables().then((vars) => consoleVariables.set(vars)); |
There was a problem hiding this comment.
using stores in +layout doesnt work that well 👍🏻
Comment on lines
+26
to
+30
| fetch(`${endpoint}/health/version`, { | ||
| headers: { 'X-Appwrite-Project': project } | ||
| }) | ||
| .then((res) => res.json().catch(() => null)) | ||
| .then((data) => version.set(data?.version)); |
There was a problem hiding this comment.
same here we stores
There was a problem hiding this comment.
if we wanna put async data into stores, it should happen with the store, in the load functions 👍🏻
| <svelte:fragment slot="header" let:root> | ||
| <Table.Header.Cell column="dueDate" {root}>Due date</Table.Header.Cell> | ||
| <Table.Header.Cell column="status" {root}>Status</Table.Header.Cell> | ||
| <Table.Header.Cell column="amount" {root}>Amount due</Table.Header.Cell> | ||
| <Table.Header.Cell column="action" {root} /> | ||
| </svelte:fragment> | ||
|
|
||
| {#if isLoadingInvoices} | ||
| {#each Array.from({ length: 2 }) as _} |
There was a problem hiding this comment.
because svelte 5 actually wants us to have keys for each. also a _ is not that clean :P
we would need to do:
Suggested change
| {#each Array.from({ length: 2 }) as _} | |
| {#each Array.from({ length: 2 }).keys() as index (index)} |
to have it clean ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)