Skip to content

fix - legacy string col not appearing - #2862

Merged
HarshMN2345 merged 2 commits into
mainfrom
string-update-field
Feb 17, 2026
Merged

fix - legacy string col not appearing#2862
HarshMN2345 merged 2 commits into
mainfrom
string-update-field

Conversation

@ArnabChatterjee20k

@ArnabChatterjee20k ArnabChatterjee20k commented Feb 17, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Screen.Recording.2026-02-17.at.6.21.59.PM.mov

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Bug Fixes
    • Improved the accuracy of column selection when editing database table columns
    • Enhanced support and handling of legacy string-type column formats in the column matching system
    • Refined the selection logic to properly identify and match columns based on their format specifications, type, and naming conventions

@appwrite

appwrite Bot commented Feb 17, 2026

Copy link
Copy Markdown

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Every Git commit and branch gets its own deployment URL automatically

@coderabbitai

coderabbitai Bot commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉


Walkthrough

A constant STRING_COLUMN_NAME was introduced in the store module to represent the legacy string column type identifier 'String (deprecated)'. The edit component now imports this constant and refines its column selection matching logic to handle three scenarios: columns with a format property (matched by format), legacy string-type columns without format (matched against the new constant), and other columns (matched by type). The changes extract a magic string into a named constant and improve type-matching behavior for backward compatibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix - legacy string col not appearing' directly addresses the main change: fixing the visibility of legacy string columns by introducing STRING_COLUMN_NAME constant and refining column selection logic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch string-update-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HarshMN2345
HarshMN2345 merged commit 2488037 into main Feb 17, 2026
4 checks passed
@HarshMN2345
HarshMN2345 deleted the string-update-field branch February 17, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants