Skip to content

Fix Integrations tab not reflecting active route #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix Integrations tab not reflecting active route #2901

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d0ca37
Initial plan
Copilot Mar 5, 2026
3a6d87c
Fix Integrations tab selection not matching nested routes
Copilot Mar 5, 2026
010f2f8
Fix tab reactivity by passing page.url.pathname directly in template
Copilot Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/routes/(console)/project-[region]-[project]/overview/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
}

function isTabSelected(key: string) {
return page.url.pathname.endsWith(`/${key}`);
return page.url.pathname.split('/').includes(key);

@stnguyen90 stnguyen90 Mar 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot this is not the issue. The tab is incorrect even when I'm on /project-x-y/overview/api-keys

Copilot AI Mar 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right - the actual issue was that page.url.pathname accessed inside a function closure isn't reactive in Svelte 5 legacy mode. The reactive dependency needs to be directly in the template expression, which is the pattern used in account/header.svelte and auth/header.svelte.

Fixed in commit 010f2f8: isTabSelected now accepts pathname as a parameter, and page.url.pathname is passed directly from the template — ensuring the template re-evaluates reactively on navigation.

}

$: $registerCommands([
Expand Down